Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await returning from the generator. #1124

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Await returning from the generator. #1124

merged 3 commits into from
Sep 2, 2021

Conversation

samscott89
Copy link
Member

In order to complete the generator and trigger the finally block which frees the ffi query object.

@github-actions
Copy link

github-actions bot commented Sep 2, 2021

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@samscott89 samscott89 requested a review from gj September 2, 2021 14:59
Copy link
Member

@gj gj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — the return() method on an async generator returns a Promise:

return(value: TReturn | PromiseLike<TReturn>): Promise<IteratorResult<T, TReturn>>;

@gj gj merged commit cf0a2ab into main Sep 2, 2021
@gj gj deleted the sam/await-js-generator branch September 2, 2021 17:21
@github-actions github-actions bot locked and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants