Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies and remove some Dialyzer warnings #16

Closed
wants to merge 7 commits into from
Closed

Bump dependencies and remove some Dialyzer warnings #16

wants to merge 7 commits into from

Conversation

optikfluffel
Copy link
Contributor

There are still a couple of them left.

lib/exdgraph/protocol.ex:50:callback_type_mismatch
Callback mismatch for @callback disconnect/2 in DBConnection behaviour.

Expected type:
:ok

Actual type:
nil
lib/exdgraph/protocol.ex:54:callback_type_mismatch
Callback mismatch for @callback handle_begin/2 in DBConnection behaviour.

Expected type:

  {:disconnect, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:error, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:ok, _, _}


Actual type:
nil
lib/exdgraph/protocol.ex:58:callback_type_mismatch
Callback mismatch for @callback handle_rollback/2 in DBConnection behaviour.

Expected type:

  {:disconnect, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:error, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:ok, _, _}


Actual type:
nil
lib/exdgraph/protocol.ex:62:callback_type_mismatch
Callback mismatch for @callback handle_commit/2 in DBConnection behaviour.

Expected type:

  {:disconnect, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:error, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:ok, _, _}


Actual type:
nil
lib/exdgraph/protocol.ex:68:pattern_match
The pattern
{:disconnect, _, _}

can never match the type

  {:error, %{:__exception__ => true, :__struct__ => atom(), atom() => _}, _}
  | {:ok, _, GRPC.Channel}

@coveralls
Copy link

coveralls commented Jul 22, 2018

Pull Request Test Coverage Report for Build 122

  • 1 of 3 (33.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 69.828%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/exdgraph/protocol.ex 0 2 0.0%
Totals Coverage Status
Change from base Build 119: -0.4%
Covered Lines: 162
Relevant Lines: 232

💛 - Coveralls

@optikfluffel optikfluffel deleted the dialyzer branch July 25, 2018 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants