Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build wheels to build both arm and x86 macos wheels #39

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

imciner2
Copy link
Member

@imciner2 imciner2 commented May 8, 2024

Github updated the macos-latest runners to be macOS 14 and the M-series aarch64 hardware, so to build both wheels, we need to run on both the new macos-latest and the old macos-13 images.

@CLAassistant
Copy link

CLAassistant commented May 8, 2024

CLA assistant check
All committers have signed the CLA.

@imciner2
Copy link
Member Author

imciner2 commented May 8, 2024

Ok, fixed the macOS arm64 build. Apparently, CPython 3.8 is x86_64 only, and so when we build using 3.8 CMake will detect the architecture as x86_64 and therefore builds QDLDL for that instead of arm64. To fix this, we just need to set the desired architecture on the CMake command line we pass in on the appropriate platform (we do native builds).

Also, we apparently reuse the build directory for the qdldl+amd library between each wheel version build, so the architecture that is used in the first build will be the architecture used for all future builds instead of it being detected again.

@imciner2
Copy link
Member Author

imciner2 commented May 9, 2024

@vineetbansal can you give this a quick look? I think this should now be generating both arm64 and x86_64 wheels for macOS now.

@AmitSolomonPrinceton AmitSolomonPrinceton merged commit 6e9ff58 into master Jun 17, 2024
11 checks passed
@AmitSolomonPrinceton AmitSolomonPrinceton deleted the im/macos branch June 17, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants