Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gawk module to use if the host is running a different major version (fixes #668) #811

Merged
merged 1 commit into from
Sep 7, 2020
Merged

Add gawk module to use if the host is running a different major version (fixes #668) #811

merged 1 commit into from
Sep 7, 2020

Conversation

NHellFire
Copy link
Contributor

No description provided.

@NHellFire
Add gawk module to use if the host is running a different major versi…
26789f7 
…on (fixes linuxboot#668)

Signed-off-by: Nathan Rennie-Waldock <nathan.renniewaldock@gmail.com>
@tlaurion
Copy link
Collaborator

@NHellFire Tested here against debian:10 docker image.
You tried to resolve the issue originating from which Host OS?

@NHellFire
Copy link
Contributor Author

@NHellFire Tested here against debian:10 docker image.
You tried to resolve the issue originating from which Host OS?

Ubuntu 20.04 has gawk 5.0.1. Build passes with this rather than failing on gpg due to the backwards-incompatible gawk changes.

tlaurion added a commit to tlaurion/heads that referenced this pull request Sep 2, 2020
@tlaurion
Testing linuxboot#811 to fix linuxboot#688 against ubuntu:20.04 which…
d1f7dd3 
… requires the fix
@tlaurion
Copy link
Collaborator

tlaurion commented Sep 2, 2020 •
edited
Loading

@NHellFire testing here. I have seen no regression, but was not able to test successful result until manually pushing heads to build against Ubuntu 20.04 and fixing timezone prompts which made last commit pointing here fail.

Build is happening here:
https://app.circleci.com/pipelines/github/tlaurion/heads/367/workflows/912d2980-526b-4535-9629-e22424154690/jobs/395

If successful, will merge. Thanks!

tlaurion added a commit to tlaurion/heads that referenced this pull request Sep 4, 2020
@tlaurion
CircleCI: testing ubuntu:20.04 with timezone hack to test linuxboot#811
c93036d
@tlaurion
Copy link
Collaborator

tlaurion commented Sep 4, 2020

@NHellFire : retesting here (past CI was failing for other reason).

@tlaurion
Copy link
Collaborator

tlaurion commented Sep 7, 2020

Functional here and doesn't cause regression

@tlaurion tlaurion merged commit 7ce12fe into linuxboot:master Sep 7, 2020
@tlaurion tlaurion mentioned this pull request Sep 10, 2020
Closed
@tlaurion tlaurion mentioned this pull request Sep 25, 2020
Closed
@tlaurion tlaurion mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NHellFire @tlaurion