-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Actor collision if loop / auto_start false #2773
Fix Actor collision if loop / auto_start false #2773
Conversation
Thank you for the pull request! The code looks reasonable. I'll give it a try in the coming weeks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR. Works for me!
I'm just going to trigger CI one more time to make sure all tests are ok. If you're motivated, it would be good to add a test to Actor_TEST exercising the fixed functionality.
@osrf-jenkins run tests please |
Sure, I will add the test. |
I added a test to
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the test! Some changes are needed for it to work on all systems, see below.
I updated the new version of the test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for iterating, this is good to go!
As reported here, when using the Actor Collision Plugin with this example, if
loop
(orauto_start
) is set tofalse
, the boxes around the actor links representing the collisions start falling around.The problem is that in such cases, the pose of the actor is not set.
This PR proposes a fix, by setting the pose of the actor based on the last animated frame when it stops.
This is the result: