Skip to content
This repository has been archived by the owner on Jul 22, 2021. It is now read-only.

[ready] Websocket server for negotiation visualizer #69

Merged
merged 22 commits into from
Aug 25, 2020
Merged

[ready] Websocket server for negotiation visualizer #69

merged 22 commits into from
Aug 25, 2020

Conversation

ddengster
Copy link
Contributor

@ddengster ddengster commented Aug 14, 2020 •
edited
Loading

  • use rmf_traffic_ros2 callbacks to send negotiation status updates and conclusions via websocket
  • respond to requests to get negotiation trajectories
  • server_keephistory.xml to retain history for testing

@ddengster
add negotiation panel with basic graph rendering
359f8b6
@ddengster
rendering trajectories
ae1fbcb 
tweaks to graph node information
added eigen dependency for some computations
@ddengster
add itinerary count information, ui adjustments, trajectory drawing
6f83a67
@ddengster
fix warning
37ec203
@ddengster
more cleanup
1815426
@ddengster
wip websocket send for negotiation status data
f8d6463
@ddengster
update to use bitflags
39f018d
@ddengster
add NegotiationStatusPublisher to handle negotiations
61794ef
@ddengster
add websocket handling of negotiation_status trajectory requests
00c5329
@ddengster
add -history option
ccf14de
@ddengster
add README information
115fc88
@ddengster
remove unused type
312d555
@ddengster
removed unnneed code, fix compile
0c6e702
@ddengster
add server_keephistory.xml for server version that keeps history
953f44f
@ddengster
convert NegotiationStatus messages to websocket message sends
2c3dfff
@ddengster
remove NegotiationPanel from rviz
d4ec54a
@ddengster
fix json message type, removed comment
d0ffad1
@ddengster
various cleanups, switch warn to log, reduce history to 50
9b9a8c8
@ddengster
uncrustify fixes
d4ecfb9
@ddengster ddengster changed the title [wip] Feature/negotiation visualizer [ready] Feature/negotiation visualizer Aug 24, 2020
@ddengster ddengster changed the title [ready] Feature/negotiation visualizer [ready] Websocket server for negotiation visualizer Aug 24, 2020
@ddengster ddengster marked this pull request as ready for review August 24, 2020 09:58
@ddengster ddengster requested review from Yadunund and mxgrey and removed request for Yadunund August 25, 2020 02:19
mxgrey
mxgrey suggested changes Aug 25, 2020
View reviewed changes
Copy link
Member

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great!

I've left some feedback to consider. Perhaps the most critical is that the _writer field isn't used and shouldn't ever be needed for a visualizer, so it should be removed.

rmf_schedule_visualizer/src/Server.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/Server.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/Server.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/Server.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/VisualizerData.hpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/Server.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/VisualizerData.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/VisualizerData.cpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/VisualizerData.hpp Outdated Show resolved Hide resolved
rmf_schedule_visualizer/src/main.cpp Outdated Show resolved Hide resolved
@ddengster ddengster mentioned this pull request Aug 25, 2020
Closed
@ddengster ddengster requested a review from mxgrey August 25, 2020 07:33
mxgrey
mxgrey approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@mxgrey mxgrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Yadunund Yadunund merged commit 06952fe into master Aug 25, 2020
@Yadunund Yadunund deleted the feature/negotiation-visualizer branch August 25, 2020 08:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Yadunund Yadunund Yadunund left review comments

@mxgrey mxgrey mxgrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ddengster @mxgrey @Yadunund