Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing URLs in globalOptions. #19

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Removing URLs in globalOptions. #19

merged 1 commit into from
Feb 11, 2019

Conversation

jubeira
Copy link
Collaborator

@jubeira jubeira commented Jan 31, 2019

See #17; requires osrf/polymer-ros-rviz#22.

@chapulina chapulina mentioned this pull request Feb 2, 2019
Open
chapulina
chapulina approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge once osrf/polymer-ros-rviz#22 is in.

@jubeira jubeira merged commit da49af8 into master Feb 11, 2019
@jubeira jubeira deleted the fix/remove_urls_config branch February 11, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubeira @chapulina