changelog: Use terminology from README #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricCousineau-TRI
force-pushed
the
feature-changelog-disambiguate-terminology
branch
from
b45101a
to
addfd97
Compare
azeey
requested changes
Apr 20, 2020
|
I pushed my fast-forward commit, and GitHub lost your review lines in the "Files Changed" view :( |
|
Addressed changes. PTAL. Will squash once this is approved (and make the DCO thing happy). |
azeey
approved these changes
Apr 20, 2020
EricCousineau-TRI
force-pushed
the
feature-changelog-disambiguate-terminology
branch
from
5e1b29d
to
d8d0be8
Compare
|
looks good, but I found a few more potential name fixes in scpeters@5896855 |
|
Will incorporate the changes shortly! |
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global> Co-Authored-By: Steven Peters <scpeters@openrobotics.org>
EricCousineau-TRI
force-pushed
the
feature-changelog-disambiguate-terminology
branch
from
d8d0be8
to
3866d69
Compare
Done. Squashed into 3866d69 |
scpeters
approved these changes
Apr 28, 2020
scpeters
added a commit
that referenced
this pull request
Jun 2, 2020
Signed-off-by: Eric Cousineau <eric.cousineau@tri.global> Co-authored-by: Steven Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a response in RobotLocomotion/drake#13105, I realized that this terminology should be put in sync with what's defined for this repo's current README.
I dunno if I should change the PR titles themselves, but I do think there should a practice of explicitly disambiguating spec (SDFormat) vs. implementation (libsdformat), especially when it comes to describing version numbers (where both diverge heavily).
FYI @scpeters