Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guide and code of conduct #431

Merged
merged 1 commit into from
Dec 10, 2020
Merged

Conversation

chapulina
Copy link
Contributor

Copied the code of conduct that we have on some Ignition libraries. I don't think it will change much, so we've been copying it instead of linking to a central place.

For the contribution guide, I linked to the central location like all Ignition libraries do. Since SDFormat isn't technically an "Ignition" library, this may be a bit odd though. Not sure what others think.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@codecov-io
Copy link

codecov-io commented Dec 7, 2020

Codecov Report

Merging #431 (4eb2c87) into master (983e8fa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #431   +/-   ##
=======================================
  Coverage   87.52%   87.52%           
=======================================
  Files          62       62           
  Lines        9542     9542           
=======================================
  Hits         8352     8352           
  Misses       1190     1190           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 983e8fa...4eb2c87. Read the comment docs.

Copy link
Collaborator

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think it's fine to say we use the Ignition contributing guide.

@chapulina chapulina merged commit 28e16c8 into master Dec 10, 2020
@chapulina chapulina deleted the chapulina/contributing branch December 10, 2020 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants