Add split/join for separating the link name from it's fully qualified name #457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
brawner
force-pushed
the
brawner/split_join_name
branch
from
d07a06b
to
b62f7af
Compare
brawner
changed the title
brawner
force-pushed
the
brawner/split_join_name
branch
from
cc42b34
to
dc2fb5b
Compare
brawner
commented
Jan 26, 2021
src/Types.cc
Outdated
| return false; | ||
|
|
||
| const size_t findStartPosition = _s.size() - kSdfScopeDelimiter.size(); | ||
| return _s.substr(findStartPosition) == kSdfScopeDelimiter; |
There was a problem hiding this comment.
This should actually just use std::string::compare(). Same in line 123
azeey
approved these changes
Jan 26, 2021
| @@ -228,6 +231,14 @@ namespace sdf | |||
| /// \param[in] _in String to convert to lowercase | |||
| /// \return Lowercase equilvalent of _in. | |||
| std::string SDFORMAT_VISIBLE lowercase(const std::string &_in); | |||
|
|
|||
| SDFORMAT_VISIBLE | |||
src/Types.cc
Outdated
| return false; | ||
|
|
||
| const size_t findStartPosition = _s.size() - kSdfScopeDelimiter.size(); | ||
| return _s.substr(findStartPosition) == kSdfScopeDelimiter; |
There was a problem hiding this comment.
nit: Probably more efficient to do _s.find(kSdfScopeDelimiter, findStartPosition) == findStartPosition as it avoids constructing a new string.
There was a problem hiding this comment.
Totally, switched to std::string::compare
Codecov Report
@@ Coverage Diff @@
## master #457 +/- ##
==========================================
+ Coverage 88.10% 88.14% +0.03%
==========================================
Files 66 66
Lines 9940 9969 +29
==========================================
+ Hits 8758 8787 +29
Misses 1182 1182
Continue to review full report at Codecov.
|
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
force-pushed
the
brawner/split_join_name
branch
from
15dd27b
to
023f9a7
Compare
scpeters
approved these changes
Jan 27, 2021
src/Types.cc
Outdated
| return _s.compare(0, kSdfScopeDelimiter.size(), kSdfScopeDelimiter) == 0; | ||
| } | ||
|
|
||
| // Join an scope name prefix with a local name using the scope delimeter |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
|
Thanks Steve for fixing the nit! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds small functionality for splitting and joining a name based on the '::' separator. It's necessary for gazebosim/gz-sim#542