-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce default heightmap sampling from 2 to 1 #459
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## master #459 +/- ##
=======================================
Coverage 88.10% 88.10%
=======================================
Files 66 66
Lines 9940 9940
=======================================
Hits 8758 8758
Misses 1182 1182
Continue to review full report at Codecov.
|
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
This PR is ready for review |
changes look good. Just need to update the heightmap test expectations to fix the failing tests |
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@scpeters , I'd like to make sure you agree with this change from the physics point of view |
There's no good reason to subsample by default, see discussion in gazebosim/gz-rendering#180 (comment).
This also needs to be changed in
Heightmap.hh
once that's merged forward, so I'll keep this PR as a draft until: