Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdformat.pc.in: requires ignition-utils1 #489

Merged
merged 1 commit into from
Feb 10, 2021

Conversation

scpeters
Copy link
Member

We updated the cmake config file in #474, but forgot to update the pkg-config file. This caused the sdformat 11.0.0~pre2 bottle build to fail: osrf/homebrew-simulation#1326

==> pkg-config sdformat11
==> /usr/bin/clang test.cpp -std=c++17 -I/usr/local/lib/pkgconfig/../..//include/sdformat-11.0 -I/usr/local/Cellar/ignition-math6/6.8.0~pre2/include/ignition/math6 -I/usr/local/lib/pkgconfig/../..//include/ignition/cmake2 -L/usr/local/Cellar/sdformat11/11.0.0~pre2/lib -lsdformat11 -lc++ -o test
In file included from test.cpp:2:
In file included from /usr/local/lib/pkgconfig/../..//include/sdformat-11.0/sdf/sdf.hh:2:
/usr/local/lib/pkgconfig/../..//include/sdformat-11.0/sdf/Actor.hh:24:10: fatal error: 'ignition/utils/ImplPtr.hh' file not found
#include <ignition/utils/ImplPtr.hh>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.

https://build.osrfoundation.org/job/generic-release-homebrew_triggered_bottle_builder/263/label=osx_catalina/console

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Copy link
Collaborator

@jennuine jennuine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scpeters
Copy link
Member Author

thanks for the review!

@scpeters scpeters merged commit 53325ed into gazebosim:master Feb 10, 2021
@scpeters scpeters deleted the pc_file_requires_utils branch February 10, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants