Add nested model support for World's *ByName and *NameExists functions
#518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
changed the title
ModelByName and ModelNameExists finds nested models too
…d, added tests Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
changed the title
ModelByName and ModelNameExists finds nested models too*ByName and *NameExists functions
Codecov Report
@@ Coverage Diff @@
## master #518 +/- ##
==========================================
+ Coverage 87.97% 87.99% +0.01%
==========================================
Files 66 66
Lines 9546 9551 +5
==========================================
+ Hits 8398 8404 +6
+ Misses 1148 1147 -1
Continue to review full report at Codecov.
|
jennuine
reviewed
Mar 19, 2021
Co-authored-by: Jenn Nguyen <jenn@openrobotics.org> Signed-off-by: Aaron Chong <aaronchongth@gmail.com>
aaronchongth
force-pushed
the
aaron/world_find_nested_models
branch
from
08d3c89
to
719b297
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Chong aaronchongth@gmail.com
🎉 New feature
Closes #412
Summary
This adds nested model support to
*ByNameand*NameExistsfunctions inWorld, specifically forModelandFrame. The implementation is the same as the one used inModel.Notes:
.sdfintegration test sdf files,world_nested_frame.sdfandworld_nested_model.sdf.Model's API as well, since these functions will call them.Test it
source ws/install/setup.bash ./ws/build/sdformat11/src/UNIT_World_TEST ./ws/build/sdformat11/test/integration/INTEGRATION_model_dom ./ws/build/sdformat11/test/integration/INTEGRATION_world_domChecklist
sh tools/code_check.sh)another open pull request
to support the maintainers
Note to maintainers: Remember to use Squash-Merge