Clean up use of PROJECT_SOURCE_PATH in tests #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
ahcorde
requested changes
Apr 27, 2021
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <alejandro@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## sdf11 #549 +/- ##
=======================================
Coverage 87.46% 87.46%
=======================================
Files 72 72
Lines 10349 10349
=======================================
Hits 9052 9052
Misses 1297 1297 Continue to review full report at Codecov.
|
azeey
reviewed
Apr 27, 2021
Signed-off-by: Michael Carroll <michael@openrobotics.org>
ahcorde
approved these changes
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧹 Clean some uses of PROJECT_SOURCE_PATH
This is partially to address compatibility with Bazel builds, but also generally better practice going forward as it handles paths more consistently across operating systems.
Signed-off-by: Michael Carroll michael@openrobotics.org