Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single registration per address with CommsBroker #33

Closed
osrf-migration opened this issue Dec 4, 2018 · 6 comments
Closed

Single registration per address with CommsBroker #33

osrf-migration opened this issue Dec 4, 2018 · 6 comments
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Jon Fink (Bitbucket: jonfink-arl).


Currently the CommsBroker only allows a single client to register per address. That is a reasonable constraint to simplify book-keeping, but currently it will never un-register a client (and there is not an API on the CommsClient to do this).

This means that repeated running of something like the subt_example_node without also restarting gazebo will result in failures like

Logger::Register() error: ID [X2] already exists
@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Just so I understand the use case, you'd like to keep Gazebo running and run your solution code multiple times?

@caguero , what do you think about adding unregister to the Comms API?

@osrf-migration
Copy link
Author

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


I think it should be possible.

https://osrf-migration.github.io/subt-gh-pages/#!/osrf/subt/pull-requests/97

@jonfink-arl , could you give it a shot?

@osrf-migration
Copy link
Author

Original comment by Jon Fink (Bitbucket: jonfink-arl).


@nkoenig Yes, that is exactly the idea.

@caguero I'll take a look at that and let you know.

@osrf-migration
Copy link
Author

Original comment by Nate Koenig (Bitbucket: Nathan Koenig).


Pull request #97 has been merged. Please resolve this issue if the problem has been fixed, or update the issue with new information/requests.

@osrf-migration
Copy link
Author

Original comment by Carlos Agüero (Bitbucket: caguero, GitHub: caguero).


  • changed state from "new" to "resolved"

See pull request #97.

@osrf-migration
Copy link
Author

Original comment by Alfredo Bencomo (Bitbucket: bencomo).


  • changed state from "resolved" to "closed"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant