Skip to content
This repository has been archived by the owner on Dec 13, 2021. It is now read-only.

Include packet []byte in PacketEvent #111

Closed
AkihiroSuda opened this issue Feb 17, 2016 · 3 comments
Closed

Include packet []byte in PacketEvent #111

AkihiroSuda opened this issue Feb 17, 2016 · 3 comments
Assignees
@AkihiroSuda
Labels
component/inspectors/ethernet component/rpc kind/enhancement priority/P2
Milestone
unplanned

Comments

@AkihiroSuda
Copy link
Member

Now earthquake has its own Ethernet inspector and does not depend on pyearthquake for Ethernet inspection.
So including packet []byte in PacketEvent makes a sense for those who want to analyze []byte in his/her own ExplorePolicy.
Perhaps @mitake is interested in this.
@AkihiroSuda AkihiroSuda self-assigned this Feb 17, 2016
@AkihiroSuda AkihiroSuda added this to the unplanned milestone Feb 17, 2016
@mitake
Copy link
Contributor

mitake commented Feb 18, 2016

@AkihiroSuda yes, it would be very useful for parsing RPC messages that can be used from golang (e.g. gRPC).

AkihiroSuda added a commit that referenced this issue Mar 3, 2016
@AkihiroSuda
inspector/ethernet: include packet []byte in PacketEvent
d0a0da9 
Now the packet bytes (type of []byte) are available as `packetEvent.JSONMap()["option"]["bytes"]`.

Fix #111
@AkihiroSuda AkihiroSuda mentioned this issue Mar 3, 2016
Merged
@AkihiroSuda
Copy link
Member Author

@mitake I closed this in #121, PTAL if you have a time.

@mitake
Copy link
Contributor

mitake commented Mar 4, 2016

@AkihiroSuda thanks, I'll look at it later.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AkihiroSuda AkihiroSuda

Labels
component/inspectors/ethernet component/rpc kind/enhancement priority/P2
Projects
None yet
Milestone
unplanned
Development

No branches or pull requests
2 participants
@mitake @AkihiroSuda