Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monsters API #135

Closed
osrsbox opened this issue Jul 18, 2019 · 1 comment
Closed

Add monsters API #135

osrsbox opened this issue Jul 18, 2019 · 1 comment
Assignees
Labels
doing Currently working on this issue/PR enhancement monsters Anything to do with the monsters data, API or builder

Comments

@osrsbox
Copy link
Owner

osrsbox commented Jul 18, 2019

The last update to adding support for monster data was building the monster JSON schema, closed in PR #134. The next logical step is to build the monsters API for use in the osrsbox package to access monster data, as well as to help build the monster database (populate the Python objects and export to JSON).

This involves:

  1. Add monster API under osrsbox directory. Have a monster_definition for base properties, and a monster_drop for monster drops - each stored in a dictionary and populated into a list. There should also be a all_monsters module for loading the monster data.
  2. Remove the monsters_api folder from the osrsbox package, so that the code isn't included with the PyPi package until the monster data has actually been added.
  3. Test the API with some faked data.
  4. Test the API/faked data with the JSON schema and pytest test monsters module.

EDIT: Although not specifically stated, this does not include the monsters_builder component to actually build the monster database. That will be the next logical step.

@osrsbox osrsbox added enhancement monsters Anything to do with the monsters data, API or builder doing Currently working on this issue/PR labels Jul 18, 2019
@osrsbox osrsbox self-assigned this Jul 18, 2019
@osrsbox
Copy link
Owner Author

osrsbox commented Aug 19, 2019

This has been added... see #16 for information.

@osrsbox osrsbox closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doing Currently working on this issue/PR enhancement monsters Anything to do with the monsters data, API or builder
Projects
None yet
Development

No branches or pull requests

1 participant