Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add sami-cli specs #2

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add sami-cli specs #2

wants to merge 2 commits into from

Conversation

elhmn
Copy link
Member

@elhmn elhmn commented Mar 28, 2022

No description provided.

Comment on lines +34 to +41
|`version` | The version of the `sami.yaml` file it is set using semantic versionning `v0`|
|`service_name` | The name of the service you want to deploy. **Example: camerdevs**
|`type` | The type of deployment you want to use can be `swarm|k8s|cron`
|`pr_deploy` | Set wheter it is a pull request deployment or not. set to `false` by default
|`files` | Is a list of deployment files. for camerdevs it should be set to `- camerdevs-stack.yml`
|`oob` | The out of band field indicate which field and file should be edited when a deployment is performed, we could change the image sha of `service.api.image` field in the `camerdevs-stack.yml` file
|`oob.[].key.path` | Path to the field we want to edit in the deployment file
|`oob.[].key.file` | name of the file to the field we want to edit in the deployment file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add :

  • a column "Required" to tell if the field is required or not
  • a column for the variable type
  • a column for dependency between other field (this field should be present only if this field is available...)


| Fields | Description |
|--------------|-----------------------|
|`version` | The version of the `sami.yaml` file it is set using semantic versionning `v0`|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the version can impact the implementation of the CLI ? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants