feat(auth): added jwt logic to the auth #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy Preview for infallible-rosalind-15c59f processing. 🔨 Explore the source changes: 6306947 🔍 Inspect the deploy log: https://app.netlify.com/sites/infallible-rosalind-15c59f/deploys/61a14c938960da000787eeee |
DipandaAser
reviewed
Nov 27, 2021
backend/app/router.go
Outdated
| // IsAuthorized This function will check the authorization from a given token in Bearer | ||
| func IsAuthorized(endpoint func(c *gin.Context)) gin.HandlerFunc { | ||
| fn := func(c *gin.Context) { | ||
|
|
There was a problem hiding this comment.
These news lines are unecessary. this will fail during linting.
Delete it
fn := func(c *gin.Context) {
if c.GetHeader("Authorization") != "" {
token, err := jwt.Parse(c.GetHeader("Authorization"), func(token *jwt.Token) (interface{}, error) {There was a problem hiding this comment.
Don't get it... what is unecessary ?
which lines ?
|
the linting check notice that the file are format with go fmt. $> make fmt |
DipandaAser
requested changes
Nov 27, 2021
backend/app/router.go
Outdated
| tokenString, err := token.SignedString(jwtSigningKey) | ||
|
|
||
| if err != nil { | ||
| fmt.Errorf("Something Went Wrong: %s", err.Error()) |
There was a problem hiding this comment.
you nedd to recupere 🤣 the value returned by fmt.Errorf()
if err != nil {
err = fmt.Errorf("Something Went Wrong: %s", err.Error())
return "", err
}There was a problem hiding this comment.
updated based on the return of the method :
if err != nil {
return "", err
}
Sanix-Darker
force-pushed
the
fix/jwt-token
branch
from
6306947
to
ff4da5f
Compare
…ade dependencies to their latest versions
* feat(ui): WIP: Banner component, chakra ui setup and translation * feat(ui): WIP: Home page integration * feat(ui): Done home page integration for big screens * fix(ui): remove top level package.json
Sanix-Darker
force-pushed
the
fix/jwt-token
branch
from
b5539e7
to
8525643
Compare
Sanix-Darker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
impact
In the future, to protect a route with the jwt token, we're going to use
app.IsAuthorized(targethandler)