Use different alert query for MySQL and PostgreSQL #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Anyone use ossec-dbd that wants to test this? |
|
Yeah I've got the test environment for this one. I'll get to it shortly |
|
I'm not having any success getting this to work with mysql, it keeps defaulting to the postgres case for some reason |
|
I honestly wouldn't be surprised if that dbtype flag isn't being set correctly. The dbd module doesn't feel very fleshed out. |
|
Right now this is a release blocking issue & we may need to revert the postgres commit |
|
Im going to close this one out, I re-implemented this PR in #824 with the break; fix Thanks again for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to @atomicturtle on this PR: #770