Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In-memory cache could cause OOM #20

Closed
naveensrinivasan opened this issue Jul 27, 2021 · 2 comments
Closed

In-memory cache could cause OOM #20

naveensrinivasan opened this issue Jul 27, 2021 · 2 comments

Comments

@naveensrinivasan
Copy link
Member

The in-memory cache is great for simple workflows. But for large repositories it usually causes OOM.

A sample repository that was causing OOM was github.com/ApolloAuto/apollo

related issue ossf/scorecard#589

allstar/pkg/ghclients/ghclients.go

Line 83 in 70d3e36

Cache: httpcache.NewMemoryCache(),

This might not be applicable for allstar but wanted to point out the issues it could run into.
@jeffmendoza
Copy link
Member

Thanks, I will do some scale testing with memory size monitoring.

@jeffmendoza
Copy link
Member

As noted, will keep this in mind. Closing for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naveensrinivasan @jeffmendoza