Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: be more specific about what Dependabot brings with it #1336

Merged
merged 2 commits into from
Dec 1, 2021
Merged

📖 docs: be more specific about what Dependabot brings with it #1336

merged 2 commits into from
Dec 1, 2021

Conversation

evverx
Copy link
Contributor

@evverx evverx commented Nov 23, 2021

It would have helped me to decide whether I needed it or not

dependabot/dependabot-core#2804 has been open for almost a year (and dependabot/dependabot-core#2198 since 2019) so it doesn't seem to make sense to wait for it to be fixed anytime soon.

It would have helped me to decide whether I needed it or not
@evverx
Copy link
Contributor Author

evverx commented Nov 24, 2021

The documentation should probably mention that RenovateBot doesn't support dependencies pinned to SHAs in a way that would be human-friendly: evverx/systemd#30 but since I'm not sure whether it's configurable or not I decided not to include it in this PR.

More generally, it would be great if before recommending anything in its documentation the scorecard project could somehow make sure that whatever it recommends is more or less usable.

@evverx
Copy link
Contributor Author

evverx commented Nov 24, 2021

I'd personally probably stop recommending CodeQL as well due its hidden security tab with alerts. It was discussed in #1257 (comment) and #1074 (comment) though

@evverx
Copy link
Contributor Author

evverx commented Nov 25, 2021

There seems to be another missing feature: dependabot/dependabot-core#2835 (comment)

Copy link
Contributor

@azeemshaikh38 azeemshaikh38 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@azeemshaikh38 azeemshaikh38 enabled auto-merge (squash) December 1, 2021 17:25
@azeemshaikh38 azeemshaikh38 temporarily deployed to integration-test December 1, 2021 17:25 Inactive
@github-actions
Copy link

github-actions bot commented Dec 1, 2021

Integration tests success for
[ea192e5]
(https://github.com/ossf/scorecard/actions/runs/1526977857)

@azeemshaikh38 azeemshaikh38 merged commit 3cf8b2b into ossf:main Dec 1, 2021
@azeemshaikh38
Copy link
Contributor

Thanks @evverx. Feel free to open issues about the comments you have added here and we can continue the discussion there.

@evverx
Copy link
Contributor Author

evverx commented Jun 12, 2023

FWIW I think this PR can be reverted because that particular Dependbot bug was fixed: https://github.blog/changelog/2022-11-07-dependabot-pull-requests-off-by-default-for-forks/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants