🐛 Avoid reading every file searching for sonar configs #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if the filename doesn't match we don't use the file content. Signed-off-by: Spencer Schrock <sschrock@google.com>
we don't save the line, just the offset. using the bytes versions avoids allocating new strings Signed-off-by: Spencer Schrock <sschrock@google.com>
spencerschrock
requested review from
naveensrinivasan and
justaugustus
and removed request for
a team
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3929 +/- ##
==========================================
+ Coverage 66.64% 68.57% +1.93%
==========================================
Files 234 234
Lines 15877 15881 +4
==========================================
+ Hits 10581 10891 +310
+ Misses 4640 4296 -344
- Partials 656 694 +38 |
naveensrinivasan
approved these changes
Mar 7, 2024
spencerschrock
temporarily deployed
to
integration-test
GitHub Actions
Inactive
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
* use reader instead of contents if the filename doesn't match we don't use the file content. Signed-off-by: Spencer Schrock <sschrock@google.com> * compare bytes to avoid allocations we don't save the line, just the offset. using the bytes versions avoids allocating new strings Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bug fix
What is the current behavior?
Every file's whole contents are read. But for any file not called
pom.xmlthis is wasted work.What is the new behavior (if this is a feature change)?**
pom.xml(should be covered by existing tests)
Which issue(s) this PR fixes
Related to #3831 (SAST won't run locally, but this will hopefully save time in the cron)
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)