-
Notifications
You must be signed in to change notification settings - Fork 473
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.1 in /tools #3966
Merged
spencerschrock
merged 7 commits into
main
from
dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.57.1
Mar 25, 2024
Merged
🌱 Bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.1 in /tools #3966
spencerschrock
merged 7 commits into
main
from
dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.57.1
Mar 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3966 +/- ##
==========================================
+ Coverage 66.77% 70.53% +3.76%
==========================================
Files 227 227
Lines 16263 16249 -14
==========================================
+ Hits 10859 11461 +602
+ Misses 4733 4063 -670
- Partials 671 725 +54 |
Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.56.2...v1.57.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
3bdbae1
to
08ebcfe
Compare
…gci/golangci-lint-1.57.1 Signed-off-by: Spencer Schrock <sschrock@google.com>
wrapcheck v2.8.3 includes a fix for false positives in func literals. Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
included at package level to ensure regex compiles at build time. These could stay as func regexes if desired, but we'd need test coverage for the piper code so we know we wont panic Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
This seems like a nice readability change anyway Signed-off-by: Spencer Schrock <sschrock@google.com>
raghavkaul
approved these changes
Mar 25, 2024
fhoeborn
pushed a commit
to fhoeborn/scorecard
that referenced
this pull request
Apr 1, 2024
…ols (ossf#3966) * 🌱 Bump github.com/golangci/golangci-lint in /tools Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.1. - [Release notes](https://github.com/golangci/golangci-lint/releases) - [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md) - [Commits](golangci/golangci-lint@v1.56.2...v1.57.1) --- updated-dependencies: - dependency-name: github.com/golangci/golangci-lint dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * remove unused wrapcheck nolint directives wrapcheck v2.8.3 includes a fix for false positives in func literals. Signed-off-by: Spencer Schrock <sschrock@google.com> * satisfy assignOp gocritic linter Signed-off-by: Spencer Schrock <sschrock@google.com> * convert const regex to MustCompile included at package level to ensure regex compiles at build time. These could stay as func regexes if desired, but we'd need test coverage for the piper code so we know we wont panic Signed-off-by: Spencer Schrock <sschrock@google.com> * satisfy unslice linter Signed-off-by: Spencer Schrock <sschrock@google.com> * satisfy wrapperFunc linter This seems like a nice readability change anyway Signed-off-by: Spencer Schrock <sschrock@google.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Spencer Schrock <sschrock@google.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Spencer Schrock <sschrock@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/golangci/golangci-lint from 1.56.2 to 1.57.1.
Release notes
Sourced from github.com/golangci/golangci-lint's releases.
... (truncated)
Changelog
Sourced from github.com/golangci/golangci-lint's changelog.
... (truncated)
Commits
cd890db
fix: filter invalid issues before other processors (#4552)921d535
build(deps): bump github.com/pelletier/go-toml/v2 from 2.1.1 to 2.2.0 (#4548)87b6bf1
build(deps): bump github.com/golangci/plugin-module-register from 0.1.0 to 0....4eae95d
dev: improve dependabot configuration9d6d793
docs: fix default value for sloglint no-global (#4547)062d985
docs: update documentation (#4546)e35fa39
docs: update documentation assets (#4545)023d78b
docs: update GitHub Action assetsddc703d
fix: disable temporarily httpresponse from govet (#4528)1b6f006
dev: silence help on some commands usage on error (#4542)You can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)