Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump github.com/golangci/golangci-lint from 1.56.2 to 1.57.1 in /tools #3966

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 21, 2024

Bumps github.com/golangci/golangci-lint from 1.56.2 to 1.57.1.

Release notes

Sourced from github.com/golangci/golangci-lint's releases.

v1.57.1

golangci-lint is a free and open-source project, built by people in their free time. Also, the linter authors are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️

The most important changes are detailed here: https://golangci-lint.run/product/changelog/#v1571

Changelog

  • 87b6bf17 build(deps): bump github.com/golangci/plugin-module-register from 0.1.0 to 0.1.1 (#4549)
  • 921d5357 build(deps): bump github.com/pelletier/go-toml/v2 from 2.1.1 to 2.2.0 (#4548)
  • cd890db2 fix: filter invalid issues before other processors (#4552)

v1.57.0

golangci-lint is a free and open-source project, built by people in their free time. Also, the linter authors are an important part of golangci-lint. If you use and appreciate golangci-lint please think to support us (golangci-lint maintainers and linter authors). ❤️

The most important changes are detailed here: https://golangci-lint.run/product/changelog/#v1570

⚠️ Important ⚠️

  1. Deprecated linters are inactivated, you still need to disable them if you are using enable-all.
  2. Deprecated CLI flags (about linter settings and deadline) have been removed.

Changelog

  • 2bcc0104 Revert "fix: deprecation message related to UseDefaultSkipDirs (#4533)"
  • 571f2fcf build(deps): bump github.com/Abirdcfly/dupword from 0.0.13 to 0.0.14 (#4398)
  • 4ee10a24 build(deps): bump github.com/Antonboom/testifylint from 1.1.2 to 1.1.3 (#4447)
  • 61f2f70d build(deps): bump github.com/Antonboom/testifylint from 1.1.3 to 1.2.0 (#4449)
  • 02ea91d7 build(deps): bump github.com/alexkohler/nakedret/v2 from 2.0.2 to 2.0.4 (#4540)
  • e5d2bc95 build(deps): bump github.com/catenacyber/perfsprint from 0.6.0 to 0.7.0 (#4386)
  • 24439292 build(deps): bump github.com/catenacyber/perfsprint from 0.7.0 to 0.7.1 (#4402)
  • b07bd18c build(deps): bump github.com/daixiang0/gci from 0.12.1 to 0.12.3 (#4400)
  • 9c492afc build(deps): bump github.com/daixiang0/gci from 0.12.3 to 0.13.0 (#4429)
  • 17e736fa build(deps): bump github.com/denis-tingaikin/go-headerfrom 0.4.3 to 0.5.0 (#4396)
  • 584520cf build(deps): bump github.com/ghostiam/protogetter from 0.3.4 to 0.3.5 (#4539)
  • f6e23692 build(deps): bump github.com/go-critic/go-critic from 0.11.1 to 0.11.2 (#4430)
  • addd06ce build(deps): bump github.com/golangci/plugin-module-register to 0.1.0 (#4510)
  • d06296eb build(deps): bump github.com/golangci/unconvert to HEAD (#4473)
  • 76ce09b5 build(deps): bump github.com/jjti/go-spancheck from 0.5.2 to 0.5.3 (#4414)
  • df70758a build(deps): bump github.com/karamaru-alpha/copyloopvar from 1.0.4 to 1.0.8 (#4444)
  • f4e33e0b build(deps): bump github.com/kunwardeep/paralleltest from 1.0.9 to 1.0.10 (#4394)
  • f8370704 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.15.2 to 0.16.0 (#4530)
  • f2d41100 build(deps): bump github.com/nunnatsa/ginkgolinter from 0.16.0 to 0.16.1 (#4531)
  • 485cb6a5 build(deps): bump github.com/ryancurrah/gomodguard from 1.3.0 to 1.3.1 (#4538)
  • d36c383f build(deps): bump github.com/shirou/gopsutil/v3 from 3.24.1 to 3.24.2 (#4446)
  • b5c339f4 build(deps): bump github.com/stretchr/testify from 1.8.4 to 1.9.0 (#4448)
  • bcd015e3 build(deps): bump github.com/tomarrell/wrapcheck/v2 from 2.8.1 to 2.8.3 (#4403)
  • ce279348 build(deps): bump go-simpler.org/musttag from 0.8.0 to 0.9.0 (#4428)

... (truncated)

Changelog

Sourced from github.com/golangci/golangci-lint's changelog.

v1.57.1

  1. Fixes:
    • Ignore issues with invalid position (e.g. contextcheck).

v1.57.0

  1. New linters
  2. Updated linters
    • dupword: from 0.0.13 to 0.0.14
    • gci: from 0.12.1 to 0.12.3
    • ginkgolinter: from 0.15.2 to 0.16.1 (new option force-expect-to, validate-async-intervals, and forbid-spec-pollution)
    • go-critic: from 0.11.1 to 0.11.2
    • go-critic: support of enable-all and disable-all options
    • go-spancheck: from 0.5.2 to 0.5.3
    • gomodguard: from 1.3.0 to 1.3.1
    • govet: deprecation of check-shadowing ⚠️
    • govet: disable temporarily httpresponse because of a bug golang/go#66259
    • misspell: add extra-words
    • musttag: from 0.8.0 to 0.9.0
    • nakedret: from 2.0.2 to 2.0.4
    • paralleltest: from 1.0.9 to 1.0.10
    • perfsprint: from 0.6.0 to 0.7.1 (new option strconcat)
    • protogetter: from 0.3.4 to 0.3.5
    • revive: add exclude option
    • sloglint: from 0.4.0 to 0.5.0 (new option no-global)
    • staticcheck: from 0.4.6 to 0.4.7
    • testifylint: from 1.1.2 to 1.2.0 (new option bool-compare)
    • unconvert: to HEAD (new options fast-math and safe)
    • wrapcheck: from 2.8.1 to 2.8.3
    • Disable copyloopvar and intrange on Go < 1.22
  3. Enhancements
    • 🧩 New custom linters system https://golangci-lint.run/plugins/module-plugins/
    • 🎉 Allow running only a specific linter without modifying the file configuration (--enable-only)
    • Allow custom sort order for the reports (output.sort-order)
    • Automatically adjust the maximum concurrency to the container CPU quota if run.concurrency=0
    • Add verify command to check the configuration against the JSON Schema
    • Option to strictly follow Go generated file convention (issues.exclude-generated-strict)
    • Syntax to not override severity from linters (@linter)
    • Use severities from gosec
    • Create automatically directory related to output.formats.path
    • Use the first issue without inline on mergeLineIssues on multiple issues
  4. Misc.
    • ⚠️ Inactivate deprecated linters (deadcode, exhaustivestruct, golint, ifshort, interfacer, maligned, nosnakecase, scopelint, structcheck, varcheck)
    • ⚠️ Deprecated CLI flags have been removed (deprecated since 2018)
    • ⚠️ Move show-stats option from run to output configuration section
    • ⚠️ Replace run.skip-xxx options by issues.exclude-xxx options
    • ⚠️ Replace output.format by output.formats with a new file configuration syntax

... (truncated)

Commits
  • cd890db fix: filter invalid issues before other processors (#4552)
  • 921d535 build(deps): bump github.com/pelletier/go-toml/v2 from 2.1.1 to 2.2.0 (#4548)
  • 87b6bf1 build(deps): bump github.com/golangci/plugin-module-register from 0.1.0 to 0....
  • 4eae95d dev: improve dependabot configuration
  • 9d6d793 docs: fix default value for sloglint no-global (#4547)
  • 062d985 docs: update documentation (#4546)
  • e35fa39 docs: update documentation assets (#4545)
  • 023d78b docs: update GitHub Action assets
  • ddc703d fix: disable temporarily httpresponse from govet (#4528)
  • 1b6f006 dev: silence help on some commands usage on error (#4542)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner March 21, 2024 08:51
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Mar 21, 2024
@dependabot dependabot bot requested review from naveensrinivasan and justaugustus and removed request for a team March 21, 2024 08:51
@dependabot dependabot bot requested a review from laurentsimon March 21, 2024 08:51
@dependabot dependabot bot temporarily deployed to integration-test March 21, 2024 08:51 Inactive
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Merging #3966 (7b4d23c) into main (deced31) will increase coverage by 3.76%.
The diff coverage is 92.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3966      +/-   ##
==========================================
+ Coverage   66.77%   70.53%   +3.76%     
==========================================
  Files         227      227              
  Lines       16263    16249      -14     
==========================================
+ Hits        10859    11461     +602     
+ Misses       4733     4063     -670     
- Partials      671      725      +54     

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.56.2...v1.57.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.57.1 branch from 3bdbae1 to 08ebcfe Compare March 25, 2024 08:14
@dependabot dependabot bot temporarily deployed to integration-test March 25, 2024 08:14 Inactive
…gci/golangci-lint-1.57.1

Signed-off-by: Spencer Schrock <sschrock@google.com>
wrapcheck v2.8.3 includes a fix for false positives in func literals.

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
included at package level to ensure regex compiles at build time.
These could stay as func regexes if desired, but we'd need test coverage
for the piper code so we know we wont panic

Signed-off-by: Spencer Schrock <sschrock@google.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
This seems like a nice readability change anyway

Signed-off-by: Spencer Schrock <sschrock@google.com>
@spencerschrock spencerschrock merged commit bf18c27 into main Mar 25, 2024
38 checks passed
@spencerschrock spencerschrock deleted the dependabot/go_modules/tools/github.com/golangci/golangci-lint-1.57.1 branch March 25, 2024 22:56
fhoeborn pushed a commit to fhoeborn/scorecard that referenced this pull request Apr 1, 2024
…ols (ossf#3966)

* 🌱 Bump github.com/golangci/golangci-lint in /tools

Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.56.2 to 1.57.1.
- [Release notes](https://github.com/golangci/golangci-lint/releases)
- [Changelog](https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md)
- [Commits](golangci/golangci-lint@v1.56.2...v1.57.1)

---
updated-dependencies:
- dependency-name: github.com/golangci/golangci-lint
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* remove unused wrapcheck nolint directives

wrapcheck v2.8.3 includes a fix for false positives in func literals.

Signed-off-by: Spencer Schrock <sschrock@google.com>

* satisfy assignOp gocritic linter

Signed-off-by: Spencer Schrock <sschrock@google.com>

* convert const regex to MustCompile

included at package level to ensure regex compiles at build time.
These could stay as func regexes if desired, but we'd need test coverage
for the piper code so we know we wont panic

Signed-off-by: Spencer Schrock <sschrock@google.com>

* satisfy unslice linter

Signed-off-by: Spencer Schrock <sschrock@google.com>

* satisfy wrapperFunc linter

This seems like a nice readability change anyway

Signed-off-by: Spencer Schrock <sschrock@google.com>

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Spencer Schrock <sschrock@google.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Spencer Schrock <sschrock@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants