✨ SARIF 2: add short description to checks.yml #848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
force-pushed
the
feat/sarif-2
branch
from
ca925b4
to
e1fafd1
Compare
inferno-chromium
approved these changes
Aug 12, 2021
|
you would need to update this pr slightly since signed tags is getting removed soon, in auto-merge. |
laurentsimon
force-pushed
the
feat/sarif-2
branch
from
bdf7b9b
to
bf4f4ff
Compare
laurentsimon
requested review from
inferno-chromium
and removed request for
naveensrinivasan and
azeemshaikh38
inferno-chromium
approved these changes
Aug 13, 2021
1 task
azeemshaikh38
approved these changes
Aug 13, 2021
There was a problem hiding this comment.
Also update REAMDE.md - https://github.com/ossf/scorecard#scorecard-checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
no short description for checks
What is the new behavior (if this is a feature change)?
add short description for checks
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information:
the SARIF format requires a short description for each result. This is use by GitHub to show a message for the offending line.
We will populate the short description in SARIF with the text from the yaml file.