Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ SARIF 3: add flag to yaml #853

Merged
merged 6 commits into from
Aug 16, 2021
Merged

Conversation

laurentsimon
Copy link
Contributor

@laurentsimon laurentsimon commented Aug 13, 2021

  • Please check if the PR fulfills these requirements
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    feature

  • What is the current behavior? (You can also link to an open issue here)
    no metadata

  • What is the new behavior (if this is a feature change)?
    add tags so we can use them in SARIF. (tags are optional in SARIF)

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    no

  • Other information:

docs/checks/checks.yaml Outdated Show resolved Hide resolved
@laurentsimon laurentsimon changed the title ✨ SARIF 3: add flag, precision and recall to yaml ✨ SARIF 3: add flag to yaml Aug 16, 2021
docs/checks/checks.yaml Outdated Show resolved Hide resolved
docs/checks/checks.yaml Outdated Show resolved Hide resolved
docs/checks/checks.yaml Outdated Show resolved Hide resolved
@laurentsimon laurentsimon enabled auto-merge (squash) August 16, 2021 21:58
@laurentsimon
Copy link
Contributor Author

@naveensrinivasan getting

/bin/bash: protoc: command not found
make: *** [Makefile:93: cron/data/metadata.pb.go] Error 127

@laurentsimon laurentsimon merged commit 0a0d292 into ossf:main Aug 16, 2021
@naveensrinivasan
Copy link
Member

@naveensrinivasan getting

/bin/bash: protoc: command not found
make: *** [Makefile:93: cron/data/metadata.pb.go] Error 127

Here is a much cleaner solution to solve this issue of generating proto files tektoncd/chains#192 which is also portable. I can take on this by reusing some of this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants