-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ SARIF 3: add flag to yaml #853
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentsimon
commented
Aug 13, 2021
laurentsimon
requested review from
inferno-chromium,
oliverchang,
azeemshaikh38 and
naveensrinivasan
and removed request for
naveensrinivasan and
azeemshaikh38
August 13, 2021 00:11
oliverchang
approved these changes
Aug 13, 2021
laurentsimon
changed the title
✨ SARIF 3: add flag, precision and recall to yaml
✨ SARIF 3: add flag to yaml
Aug 16, 2021
laurentsimon
force-pushed
the
feat/sarif-3
branch
from
August 16, 2021 19:56
f943353
to
8bfd3a3
Compare
inferno-chromium
approved these changes
Aug 16, 2021
@naveensrinivasan getting
|
Here is a much cleaner solution to solve this issue of generating proto files tektoncd/chains#192 which is also portable. I can take on this by reusing some of this code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
no metadata
What is the new behavior (if this is a feature change)?
add tags so we can use them in SARIF. (tags are optional in SARIF)
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
no
Other information: