Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lazily scan for profiles #2

Open
andreacalia opened this issue Nov 18, 2020 · 0 comments
Open

Lazily scan for profiles #2

andreacalia opened this issue Nov 18, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@andreacalia
Copy link
Member

At the moment on the WonderlandContextSelector the profiles are discovered in the create factory method.

This maybe is not so nice since we have the showSelectionIfUnconfigured() fluent closing clause. The user might expect that showSelectionIfUnconfigured() doesn't have the side effect of discovering the profiles in case they are already configured via spring.profiles.active property.

One possible light solution is to have a lazily evaluated discovery, so that only if needed we scan the classpath 🙂
@andreacalia andreacalia added the enhancement New feature or request label Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andreacalia