Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor backend, Replace frontend toolchain, Update docker config #27

Merged
merged 18 commits into from
Jul 16, 2022

Conversation

hrz6976
Copy link
Collaborator

@hrz6976 hrz6976 commented Jul 14, 2022

This PR changes:

  • frontend: webpack -> vite (much faster builds, hmr support)
  • docker: updated configs (+ scripts, persists nltk&certs&models)
  • backend: flask -> fastapi (better perf with query optimizations, typed, api docs)
    Please close Toolchain chores #25 after merge ☺️

@hrz6976 hrz6976 added the WIP work in progress label Jul 14, 2022
@hrz6976 hrz6976 removed the WIP work in progress label Jul 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #27 (a905ed5) into main (b94ffa0) will increase coverage by 13.57%.
The diff coverage is 68.52%.

@@             Coverage Diff             @@
##             main      #27       +/-   ##
===========================================
+ Coverage   67.64%   81.22%   +13.57%     
===========================================
  Files          17       23        +6     
  Lines        2318     2524      +206     
===========================================
+ Hits         1568     2050      +482     
+ Misses        750      474      -276     
Impacted Files Coverage Δ
gfibot/data/update.py 87.77% <ø> (+0.55%) ⬆️
gfibot/backend/scheduled_tasks.py 37.20% <37.20%> (ø)
gfibot/backend/server.py 61.70% <61.70%> (ø)
gfibot/backend/routes/github.py 69.72% <69.72%> (ø)
gfibot/backend/routes/model.py 70.00% <70.00%> (ø)
gfibot/backend/routes/repos.py 76.97% <76.97%> (ø)
gfibot/backend/background_tasks.py 77.38% <77.38%> (ø)
gfibot/backend/routes/user.py 78.57% <78.57%> (ø)
gfibot/backend/routes/issue.py 83.87% <83.87%> (ø)
gfibot/__init__.py 89.28% <84.61%> (-4.84%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94ffa0...a905ed5. Read the comment docs.

@hehao98 hehao98 merged commit 000d391 into osslab-pku:main Jul 16, 2022
@hrz6976 hrz6976 deleted the refactor-backend branch August 15, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants