JSON: properly escape json strings #1758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
force-pushed
the
3.0release
branch
29 times, most recently
from
ccd8c86
to
b59c37e
Compare
winlinvip
force-pushed
the
3.0release
branch
2 times, most recently
from
1ca9308
to
8d44b98
Compare
|
Thanks for your PR, it's important to escape the special char for JSON. 👍 I think it's better to use https://github.com/udp/json-parser to marshal the JSON object. |
winlinvip
changed the title
winlinvip
pushed a commit
that referenced
this pull request
Oct 20, 2021
|
Merged as 34b968a I wrote some utest to verify it. |
winlinvip
added a commit
that referenced
this pull request
Oct 20, 2021
winlinvip
added a commit
that referenced
this pull request
Oct 20, 2021
winlinvip
added a commit
that referenced
this pull request
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for #1757