Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix multiple PPS parse error #2104

Closed
wants to merge 1 commit into from
Closed

Conversation

mypopydev
Copy link

Signed-off-by: Jun Zhao barryjzhao@tencent.com

Signed-off-by: Jun Zhao <barryjzhao@tencent.com>
@codecov-io
Copy link

codecov-io commented Dec 23, 2020

Codecov Report

Merging #2104 (1280c3c) into develop (ec212b7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2104   +/-   ##
========================================
  Coverage    56.23%   56.23%           
========================================
  Files          125      125           
  Lines        54169    54169           
========================================
  Hits         30464    30464           
  Misses       23705    23705           

| Impacted Files | Coverage Δ | |'

'| Impacted Files | Coverage Δ | |
|---|---|---|
| trunk/src/kernel/srs_kernel_codec.cpp | 90.82% <ø> (ø) | |


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec212b7...1280c3c. Read the comment docs.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

winlinvip commented Dec 24, 2020

If there are multiple SPS/PPS, how should they be parsed?
According to the current modification, only the first SPS/PPS will be parsed, right? Is that not a problem?

TRANS_BY_GPT3

@mypopydev
Copy link
Author

mypopydev commented Dec 24, 2020

If there are multiple SPS/PPS, how should they be parsed?
According to the current modification, only the first SPS/PPS will be parsed, right? Is that not a problem?

Actually, there is a potential issue with that, but I think it's a separate problem.

TRANS_BY_GPT3

@winlinvip
Copy link
Member

Fixed by #2544

@winlinvip winlinvip closed this Aug 27, 2021
@winlinvip winlinvip added the TransByAI Translated by AI/GPT. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TransByAI Translated by AI/GPT.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants