-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SRT: Fix bug for multiple NALUs, when configure OBS in zerolatency. #2440
Conversation
srs_info("mpegts: demux avc ibp frame size=%d, dts=%d", frame_size, dts); | ||
if ((err = write_h264_ipb_frame(frame, frame_size, dts, pts)) != srs_success) { | ||
srs_info("mpegts: demux avc ibp frame size=%d, dts=%d", avs_ptr->left() + frame_size, dts); | ||
if ((err = write_h264_ipb_frame(avs_ptr->head() - frame_size, avs_ptr->left() + frame_size, dts, pts)) != srs_success) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a mistake here, head() - frame_size is a wild pointer?
TRANS_BY_GPT3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I probably understand.
Slice multiple frames and NALUs, previously sent one by one.
Now, after parsing the SPS/PPS, the rest is ignored and sent directly merged.
TRANS_BY_GPT3
Codecov Report
@@ Coverage Diff @@
## develop #2440 +/- ##
========================================
Coverage 42.77% 42.77%
========================================
Files 101 101
Lines 35944 35944
========================================
Hits 15376 15376
Misses 20568 20568 Continue to review full report at Codecov.
Translated to English:
|
…2440) * solve srt push bugs * solve h264 mutiple nalus in srt when obs is configured in zerolatency * optimize error code * optimize error code * optimize error code * add commemnt:we only skip pps/sps frame and send left nalus in srt * add commemnt:we only skip pps/sps frame and send left nalus in srt Co-authored-by: shiwei <shiwei05@kuaishou.com>
issue: #2390
the bug happen when obs push srt stream and configue h264 in zerolatency.