-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live: Limit cached max frames by gop_cache_max_frames #3236
Merged
winlinvip
merged 10 commits into
ossrs:develop
from
bluestn:feature_gop_cache_max_frames
Nov 22, 2022
Merged
Live: Limit cached max frames by gop_cache_max_frames #3236
winlinvip
merged 10 commits into
ossrs:develop
from
bluestn:feature_gop_cache_max_frames
Nov 22, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 10, 2022
winlinvip
reviewed
Nov 11, 2022
winlinvip
reviewed
Nov 11, 2022
OK, modified as you pointed out. thank u. How to verify this patch can work?
git clone https://github.com/bluestn/flv_remove_keyframe.git
mkdir -p flv_remove_keyframe/build
cd flv_remove_keyframe/build
cmake ..
make
cp ~/git/srs/trunk/doc/source.flv .
./flv_remove_keyframe source.flv
|
Verified, it works! 👍 Before this patch, the gop cache increases: After this patch, we will clear the gop cache: And the memory is ok now. |
winlinvip
changed the title
Limit max frames in gop cache by gop_cache_max_frames
Live: Limit cached max frames by gop_cache_max_frames
Nov 22, 2022
winlinvip
force-pushed
the
feature_gop_cache_max_frames
branch
from
November 22, 2022 04:00
0809a99
to
463f15c
Compare
winlinvip
reviewed
Nov 22, 2022
winlinvip
reviewed
Nov 22, 2022
winlinvip
reviewed
Nov 22, 2022
…limit to after key frame check.
winlinvip
force-pushed
the
feature_gop_cache_max_frames
branch
from
November 22, 2022 04:31
463f15c
to
0bd96ed
Compare
winlinvip
added a commit
to winlinvip/srs
that referenced
this pull request
Nov 23, 2022
winlinvip
added a commit
that referenced
this pull request
Nov 23, 2022
winlinvip
added a commit
that referenced
this pull request
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use gop_cache_max_frames to limit the max frames which can be cached by gop cache, to keep srs from run out of memory while some malicious stream pusher never send any Key frames.