-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTC: fix rtc publisher pli cid #3318
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winlinvip
reviewed
Dec 16, 2022
winlinvip
force-pushed
the
5.0release
branch
22 times, most recently
from
December 31, 2022 11:37
623e02f
to
7bdb727
Compare
xiaozhihong
force-pushed
the
bugfix/rtc-pli-cid
branch
from
January 16, 2023 12:32
989fc3e
to
a4e7427
Compare
winlinvip
previously approved these changes
Jan 17, 2023
winlinvip
force-pushed
the
bugfix/rtc-pli-cid
branch
from
January 17, 2023 13:42
0cf3ca6
to
3a85ae7
Compare
winlinvip
approved these changes
Jan 17, 2023
chen-guanghua
approved these changes
Jan 17, 2023
Check by WebRTC publish and play:
|
Check by
After RTC2RTMP, the bridge initiates a PLI request, causing both play and publish to be the same. This confusion is too significant. Can we use the bridge's CID for play? Also, the bridge for RTC2RTMP does not have any logs. It would be helpful to add a log to identify the context of this issue.
|
xiaozhihong
commented
Jan 18, 2023
winlinvip
approved these changes
Jan 19, 2023
winlinvip
added a commit
that referenced
this pull request
Jan 19, 2023
* RTC: fix rtc publisher pli cid * RTC: log bridge request keyframe * Update release v6.0.19 v5.0.138 PICK 7922057 Co-authored-by: Winlin <winlin@vip.126.com> Co-authored-by: ChenGH <chengh_math@126.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTC publisher cycle request PLI, use correct context id.