WHIP: Improve WHIP deletion by token verification. #3595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chundonglinlin
approved these changes
Jul 1, 2023
winlinvip
added a commit
that referenced
this pull request
Jul 1, 2023
…3595) ------ Co-authored-by: chundonglinlin <chundonglinlin@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to talk at CommCon, the WHIP DELETE may be security risk if not verify.
In Sandro Gauci's talk at CommCon, he mentioned that the WHIP DELETE could pose a security risk if not properly verified. We have added a token for verification, but in the future, we should consider supporting Bear tokens for enhanced security.
See WebRTC & Video Delivery application security - what could possibly go wrong? for more details.
See FFmpeg commit WHIP: Enhance security by using BearToken for delete API.