This repository has been archived by the owner on Nov 7, 2024. It is now read-only.
Fix a few clippy lints from new Rust 1.59 version #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlebon
reviewed
Feb 24, 2022
lib/src/container/encapsulate.rs
Outdated
| labels.insert(k.into(), v.into()); | ||
| } | ||
| // Lookup the cmd embedded in commit metadata | ||
| let cmd = commit_meta.lookup::<Vec<String>>(ostree::COMMIT_META_CONTAINER_CMD)?; | ||
| // But support it being overridden by CLI options | ||
| let cmd = config.cmd.as_ref().or_else(|| cmd.as_ref()); | ||
| let cmd = config.cmd.as_ref().or(cmd.as_ref()); |
There was a problem hiding this comment.
Clippy is not liking this change.
There was a problem hiding this comment.
Ah awesome, old clippy doesn't like new code, new clippy doesn't like old code. Well, we can deal with this one when we update the CI pinned clippy.
There was a problem hiding this comment.
Took this to rust-lang/rust-clippy#7639 (comment)
cgwalters
force-pushed
the
misc-clippy
branch
from
4ce9603
to
344cdb1
Compare
cgwalters
changed the title
jlebon
approved these changes
Feb 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a few clippy lints from new Rust 1.59 version