Fix clippy lints #627
Fix clippy lints #627
Conversation
Signed-off-by: John Eckersberg <jeckersb@redhat.com>
| let mut import_config = TarImportConfig::default(); | ||
| import_config.allow_nonusr = options.allow_nonusr; | ||
| import_config.remap_factory_var = !options.retain_var; | ||
| let import_config = TarImportConfig { |
There was a problem hiding this comment.
This one is subtle; there may be a better way to handle this but the idea here is we don't want the code to stop compiling when a new field is added to TarImportConfig so I think we still at least want a ..Default::default() at the end.
There was a problem hiding this comment.
Doing it that way runs afoul of needless_update, but that in turn hints at the proper solution in this case - mark the struct as non_exhaustive if it could gain extra fields in the future. Just have to be careful adding that to a public struct since it's a breaking change, but in this instance TarImportConfig is pub(crate) so it's not exposed in the API.
There was a problem hiding this comment.
Ah right, yeah we should be using non_exhaustive then on other structs. Something to keep in mind for the next API bump.
OTOH I was thinking about folding this repository into bootc, which would simplify things some.
Signed-off-by: John Eckersberg jeckersb@redhat.com