Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add public API for kargs #1833

Closed
jlebon opened this issue Mar 21, 2019 · 2 comments
Closed

Add public API for kargs #1833

jlebon opened this issue Mar 21, 2019 · 2 comments
Labels
good-first-issue good issue for someone new

Comments

@jlebon
Copy link
Member

jlebon commented Mar 21, 2019

So it can be shared with e.g. rpm-ostree. See e.g. coreos/rpm-ostree#1013 and coreos/rpm-ostree#1796.
@jlebon jlebon added the good-first-issue good issue for someone new label Mar 21, 2019
@jlebon jlebon mentioned this issue Mar 21, 2019
Closed
@jlebon
Copy link
Member Author

jlebon commented May 27, 2019

So for more context on this: rpm-ostree uses a copy of the internal kargs API here. We then added additional APIs on top of this for rpm-ostree kargs. So this would involve (1) making public the current kargs API, (2) upstreaming the new APIs from rpm-ostree and (3) dropping it from rpm-ostree and switching over to use the new libostree API.

@zonggen zonggen mentioned this issue May 28, 2019
Closed
@zonggen zonggen mentioned this issue Jun 6, 2019
Closed
zonggen pushed a commit to zonggen/ostree that referenced this issue Jun 14, 2019
lib/kargs: Upstream the new kargs APIs from rpm-ostree
dd19867 
This change makes public the current kargs API in src/libostree/ostree-kernel-args.c
and adds documentations.

Upstreams the new kargs API from rpm-ostree/src/libpriv/rpmostree-kargs-process.c

Merges libostree_kernel_args_la_SOURCES to libostree_1_la_SOURCES in Makefile-libostree.am

Upstreams tests/check/test-kargs.c from rpm-ostree.

Closes: ostreedev#1833
zonggen pushed a commit to zonggen/ostree that referenced this issue Jun 17, 2019
lib/kargs: Make API public and upstream new rpm-ostree APIs
e89063d 
This change makes public the current kargs API in src/libostree/ostree-kernel-args.c
and adds documentations.

Upstreams the new kargs API from rpm-ostree/src/libpriv/rpmostree-kargs-process.c

Merges libostree_kernel_args_la_SOURCES to libostree_1_la_SOURCES in Makefile-libostree.am

Upstreams tests/check/test-kargs.c from rpm-ostree.

Closes: ostreedev#1833
zonggen pushed a commit to zonggen/ostree that referenced this issue Jun 18, 2019
lib/kargs: Make API public and upstream new rpm-ostree APIs
7966f56 
This change makes public the current kargs API in src/libostree/ostree-kernel-args.c
and adds documentations.

Upstreams the new kargs API from rpm-ostree/src/libpriv/rpmostree-kargs-process.c

Merges libostree_kernel_args_la_SOURCES to libostree_1_la_SOURCES in Makefile-libostree.am

Upstreams tests/check/test-kargs.c from rpm-ostree.

Closes: ostreedev#1833
@jlebon
Copy link
Member Author

jlebon commented Jun 27, 2019

Follow-up in coreos/rpm-ostree#1862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue good issue for someone new
Projects
None yet
Milestone
No milestone
1 participant
@jlebon