-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ostree-2019.3 spams terminal with gpg-connect-agent messages for every flatpak operation #1907
Comments
Likely fallout from #1799 |
Sorry, I have a patch for it for a different thing I was working on. I tried to check if it was needed for any current operations, but it didn't seem like it. The issue is that Anyways, I'll split my patch out to a separate PR. Sorry for not sending it when I first noticed it. |
When listing GPG keys, the temporary GPG homedir will be constructed by simply copying the remote's trusted keys to the pubring.gpg file. In that case, no GPG operations spawning gpg-agent will be run. When gpg-connect-agent is run to cleanup the homedir, it will helpfully print on stderr that it's starting gpg-agent like so: gpg-connect-agent: no running gpg-agent - starting '/usr/bin/gpg-agent' gpg-connect-agent: waiting for the agent to come up ... (5s) gpg-connect-agent: connection to agent established Send gpg-connect-agent's stderr to a pipe and only send it to the application's stderr if an error was encountered. Fixes: ostreedev#1907
When listing GPG keys, the temporary GPG homedir will be constructed by simply copying the remote's trusted keys to the pubring.gpg file. In that case, no GPG operations spawning gpg-agent will be run. When gpg-connect-agent is run to cleanup the homedir, it will helpfully print on stderr that it's starting gpg-agent like so: gpg-connect-agent: no running gpg-agent - starting '/usr/bin/gpg-agent' gpg-connect-agent: waiting for the agent to come up ... (5s) gpg-connect-agent: connection to agent established Send gpg-connect-agent's stderr to a pipe and only send it to the application's stderr if an error was encountered. Fixes: ostreedev#1907 Closes: ostreedev#1908 Approved by: cgwalters
With
ostree-2019.3-3.fc30.x86_64
I see this:With
ostree-2019.2-1.fc30.x86_64
I see this:Compare for yourself which one looks more readable. The gpg-agent messages are printed out very frequently, for a single
flatpak update
command that has "nothing to do", I saw about 20 lines of gpg-agent messages (depends on what's happening in the background, usually it's just 3-6 lines of messages).This is happening on Fedora 30, but Arch users see it as well:
https://bbs.archlinux.org/viewtopic.php?id=248745
This happens regardless of
gpg-agent
actually running or not running in the background.The text was updated successfully, but these errors were encountered: