static-delta: Change show to display from/to commits
#1823
Conversation
When writing a delta to a file this may not always be recorded in the filename, and it's useful data. Ref: https://mail.gnome.org/archives/ostree-list/2019-February/msg00000.html This also required teaching `show` to accept a file path. Note...for some reason `test-deltas.sh` breaks when run from a tty - we get `SIGTTIN` which implies something is reading from the tty but it wasn't obvious to me what.
|
Hi Colin, Thank you very much for this patch. I think this will be a useful feature for ostree. I was able to pull and compile your branch,delta-dump-filename, however the show command didn't quite work for me. My machine doesn't have the main ostree commit repo because that lives on our build server. I figured making an empty repo on my machine would suffice as I'm only interested in running the show command to retrieve the start and end commits from the static-delta. davis@Precision-7920:/tmp$ mkdir ostree-repo Please let me know what you think. Thank you, Davis |
|
☀️ Test successful - status-atomicjenkins |
When writing a delta to a file this may not always be recorded
in the filename, and it's useful data.
This also required teaching
showto accept a file path.Note...for some reason
test-deltas.shbreaks when run froma tty - we get
SIGTTINwhich implies something is reading fromthe tty but it wasn't obvious to me what.