ci: use fcosKola for running kola tests
#2029
Conversation
We were using `--no-test-exit-error` for upgrade tests but weren't actually checking for test failures after. Instead of running kola directly, just use the `fcosKola` custom step which automatically takes care of e.g. running tests in parallel and archiving results.
|
Whee now this is blocked too... |
|
A lot of lessons learned from this...among them that I clearly should have at least done a Now that we have this CI set up, plus the run-ext-bin work will get us in a better place. It's tempting to just force merge things here and push through rather than trying to hack it... |
|
/override continuous-integration/jenkins/pr-merge |
|
@cgwalters: Overrode contexts on behalf of cgwalters: continuous-integration/jenkins/pr-merge In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We were using
--no-test-exit-errorfor upgrade tests but weren'tactually checking for test failures after.
Instead of running kola directly, just use the
fcosKolacustom stepwhich automatically takes care of e.g. running tests in parallel and
archiving results.