main: add support for CLI extensions via external binaries #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds some logic to detect and dispatch unknown subcommands to extensions available in `$PATH`. Additional commands can be implemented by adding relevant `ostree-$verb` binaries to the system. As an example, if a `/usr/bin/ostree-extcommand` extension is provided, the execution of `ostree extcommand --help` will be dispatched to that as `ostree-extcommand extcommand --help`.
lucab
force-pushed
the
ups/cli-extensions
branch
from
faa84f0
to
513b3c0
Compare
cgwalters
approved these changes
Dec 20, 2021
Comment on lines
+15
to
+16
| ${CMD_PREFIX} ostree env --help >out.txt | ||
| assert_file_has_content out.txt "with an empty environment" |
There was a problem hiding this comment.
How about e.g.:
Suggested change
| ${CMD_PREFIX} ostree env --help >out.txt | |
| assert_file_has_content out.txt "with an empty environment" | |
| ${CMD_PREFIX} env sometestenv=foo ostree env >out.txt | |
| assert_file_has_content out.txt '^sometestenv=foo` |
or so?
There was a problem hiding this comment.
I also realized there were some leftovers in the environment. #2501 takes care of all that.
|
Eh rather than re-roll CI for a nit, just going to merge; we can do the above as a followup. |
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jan 8, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jan 12, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
cgwalters
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Jan 12, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Jan 14, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
cgwalters
added a commit
to cgwalters/coreos-assembler
that referenced
this pull request
Feb 2, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
cgwalters
added a commit
to coreos/coreos-assembler
that referenced
this pull request
Feb 3, 2022
We can do this now that ostree 2022.1 is out with ostreedev/ostree#2500 There are two notable aspects to this: - Previously the code here was a mix of `ostree` and `rpm-ostree`; but it's all "pure ostree stuff", and now it is all much more consistent. This also helps us eventually put more functionality in `ostree` that was formerly in `rpm-ostree`. - We're kind of implicitly saying the container bits aren't experimental anymore, which...they probably shouldn't be in rpm-ostree side either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some logic to detect and dispatch unknown subcommands to
extensions available in
$PATH. Additional commands can beimplemented by adding relevant
ostree-$verbbinaries to the system.As an example, if a
/usr/bin/ostree-extcommandextension is provided,the execution of
ostree extcommand --helpwill be dispatched to thatas
ostree-extcommand extcommand --help.Closes: #2480