Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to external composefs #3108

Merged
merged 3 commits into from
Apr 12, 2024

Conversation

cgwalters
Copy link
Member

Since there's now a stable shared library, let's use it.

@cgwalters cgwalters force-pushed the use-external-composefs branch 2 times, most recently from fde20ee to d61ebc9 Compare December 3, 2023 20:01
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane offhand.

For CI, short-term easiest is to just run ci/installdeps.sh in the build container until the buildroot image catches up.

@cgwalters
Copy link
Member Author

I've belatedly realized that not having composefs shipped in current c9s is going to make this more logistically complicated. I think that will likely happen, but hard to say when.

@alexlarsson
Copy link
Member

Yeah, for practical reason, maybe hold off on this a bit.

@cgwalters
Copy link
Member Author

OK composefs is in c9s, rebased 🏄

@cgwalters
Copy link
Member Author

Yeah, various CI failures because our build/runtime deps come from packaging and that breaks when dropping in new binaries. I did https://src.fedoraproject.org/rpms/ostree/c/b64d73f3718115cb9d6926275e21f5b16c3f14f9?branch=rawhide as one fix.

@cgwalters cgwalters force-pushed the use-external-composefs branch 2 times, most recently from 9685989 to 3e2d44e Compare March 14, 2024 23:10
@cgwalters
Copy link
Member Author

Ah, this needs coreos/fedora-coreos-config#2900 at least

Previously this was masked by us shipping composefs vendored.
Right now there's skew where we don't have composefs-devel
in the buildroot.  In general this optimization isn't worth it.
Since there's now a stable shared library, let's use it.
@cgwalters cgwalters merged commit 818af91 into ostreedev:main Apr 12, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants