テストの追加 #616
Merged
テストの追加 #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eri-0910
approved these changes
Dec 6, 2021
| ) | ||
| }) | ||
|
|
||
| test("異常系_存在しないtopicには投稿できない", (resolve) => { |
There was a problem hiding this comment.
異常系、存在しないトピックだけじゃなくて開始していないトピックに送れないのもチェックしていいかもしれない。
There was a problem hiding this comment.
d516ce7
追加しました〜
| ) | ||
| }) | ||
|
|
||
| test("正常系_Reactionの投稿", (resolve) => { |
There was a problem hiding this comment.
存在しないMessageへのリアクション(&Question)……は考えなくていいか……
There was a problem hiding this comment.
まあ統合テストなのでそこまで細かくテストしなくてもいいかなと...
ここの機能は単体テストでカバーしているので。（リポジトリのテストも後で書きます）
Comment on lines
+917
to
+920
| // TODO: 結果が不安定でたまに失敗する（DBへのインサートの順序が実行時依存なのがおそらくの原因）のでskipにしている。 | ||
| // このエンドポイントのレスポンスの方を仕様通りに直せばchatItemsのパラメータにexpect.arrayContaining()が使えるので、 | ||
| // おそらくはそれで解決できそう。 | ||
| test.skip("正常系_終了したルームのチャットアイテムの履歴を見れる", async () => { |
There was a problem hiding this comment.
作っておきました
#645
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #441
やったこと
chat.tsというファイルにテストを追加したやっていないこと
動作確認手順
/app/server直下でyarn test参考リンク・補足など