fix: 🐛 correctly export meta for ESM types

[jimmy-guzman]

Not entirely sure why this is happening, but when we have:

import * as meta from "./meta"

It leads to:

declare const meta: typeof __metadeclare const rules: {
    [key: string]: eslint.Rule.RuleModule;
};

Which leads to a TypeScript error: ',' expected.ts(1005).

Changing it to:

import { name, version } from "./meta"

export const plugin = {
  meta: { name, version },
  environments,
  rules,
  processors,
}

Leads to:

declare const meta: {
    name: string;
    version: string;
};
declare const rules: {
    [key: string]: eslint.Rule.RuleModule;
};

Which should be the correct output.

[changeset-bot]

🦋 Changeset detected

Latest commit: a9a5bfb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
eslint-plugin-astro	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[ota-meshi]

That's a very interesting bug. It's probably a bug in the bundler, but I agree that we need a workaround.

Could you please add test cases to tests/integration where we can confirm that the correction was made?

[jimmy-guzman]

That's a very interesting bug. It's probably a bug in the bundler, but I agree that we need a workaround.

Could you please add test cases to tests/integration where we can confirm that the correction was made?

Yeah I'll look into adding a test. I'll also look into reporting this in tsup or what's powering --dts.

[ota-meshi]

Hmm. I thought the command should succeed. Was it wrong?

[jimmy-guzman]

It is passing but for some reason it's landing on the catch block. I'll take another look.

I know what's happening, i'll update.

[ota-meshi]

Oh, I get it! I was writing the test case incorrectly.
My previously written test case should have been:

      try {
        // ...
        fs.writeFileSync(actualFile, `no error:${res}`)
-        assert.fail("Expect error")
      } catch (e: any) {
        // ...
+        return
      }
+      assert.fail("Expect error")

The only test case we'll probably add is:

    it("should NOT fail when running tsc", () => {
      cp.execSync(`npx tsc`, { cwd: TEST_CWD })
    })

[jimmy-guzman]

Yeah just realize that as well, pushed a changed.

[ota-meshi]

LGTM! Thank you so much!