Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deep symlink copy doesn't work with relative ../foo target #97

Closed
samuel-phan opened this issue Jan 17, 2023 · 1 comment · Fixed by #98
Closed

Deep symlink copy doesn't work with relative ../foo target #97

samuel-phan opened this issue Jan 17, 2023 · 1 comment · Fixed by #98

Comments

@samuel-phan
Copy link
Contributor

Deep symlink copy will fail in this situation:

test
├── data
│   ├── case00
│   │   └── README.md
│   ├── case01
│   │   └── README.md
│   ├── case02
│   │   └── README.md
│   ├── case03
│   │   ├── README.md
│   │   ├── case01 -> test/data/case01
│   │   └── relative_case01 -> ../case01

Though it's entirely acceptable to have a symlink working only at a certain current working dir, most of the time, we have symlinks:

  • either to an absolute path
  • or relative to itself (eg ../something). 🐛 This case doesn't work properly.
@kernel164
Copy link

Screenshot 2023-11-13 at 9 51 28 PM

changing from os.Readlink to filepath.EvalSymlinks worked in my local.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants