Adding features from #998

[nekiro]

This pr resolves #998
I have added requested attributes, not sure if the bounty is still valid and to be claimed?

Usage for dynamic reflect, reflect chance and boosts

local item = player:addItem(8877, 1)
if item then
	item:setBoostPercent(COMBAT_PHYSICALDAMAGE, 200)
        item:setReflect(COMBAT_PHYSICALDAMAGE, {percent = 10, chance = 100})
end

New lua methods:

item:setReflect(combatType, reflect)
item:getReflect(combatType, total = true)

reflect = {percent = 0, chance = 0}

item:setBoostPercent(combatType, value)
item:getBoostPercent(combatType, total = true)

Total argument in both methods means return also the ability value (items.xml attributes)

I didn't implement, but they can be implemented if requested:

absorbpercentmonsters
absorbpercentplayers

and these too, cause they are achiveable through using boosts

increasemeleevalue
increasemeleepercent

increasemagicvalue
increasemagicpercent

increasehealingvalue
increasehealingpercent

[Znote]

Here is the new bounty link:
https://www.bountysource.com/issues/5013382-missing-item-attributes

It appears its still valid and possible to be claimed.

It appears to have tagged this PR as a solution.

[EPuncker]

adding the following to a spike sword:

<attribute key="reflectpercentphysical" value="99" />
<attribute key="reflectchancephysical" value="99" />

won't work, and spams the server console with "99" (whatever number is used in the value)

edit: I noticed it only works with armors, not weapons 😝 , makes sense
edit2: Using reflectpercentall displays everything correct but with a "undefined" included, I don't know why

I don't know if you are taking suggestions in this PR since its pretty done already, but the system would be really complete having these:

Resist: reduce damage by x%
Absorb: reduce damage by x%, heal x%
Reflect: take full damage, deal x% to attacker
Deflect: reduce damage by x%, deal x% to attacker

thanks for this PR nekiro

and @Znote your bounty link is not working (internal server error)

[nekiro]

@EPuncker did you just try to use reflect (which works when you get damage and it reflects it) on sword? How did you think that would work xD
Yeah all refers to all, undefined is one of the combat types, so its included too.

[Leo32onGIT]

@DSpeichert label/review

[nekiro]

I will rework this pr, because using consts as numbers in custom attributes is unsafe, cause people can overwrite that by setting number values in custom attribute by accident. Safer approach is to use string values.

I'll just block these numbers from setCustomAttribute

Ended up reworking the code, lol

[trzzu]

Reflect works good but boosts doesn't works.

I add to item attributes this line: <attribute key="boostpercentenergy" value="150" />
and its change nothing in player damage.

[Sansero1]

Reflect works good but boosts doesn't works.

I add to item attributes this line: <attribute key="boostpercentenergy" value="150" />
and its change nothing in player damage.

same problem here
@nekiro

[trzzu]

Boosts increase damage only on items, damage from spells not increase.

[DSpeichert]

Isn't this overlapping with #3864 ?

[nekiro]

Isn't this overlapping with #3864 ?

no, increasedamage is most likely the only similarity

[nekiro]

Reflect works good but boosts doesn't works.

I add to item attributes this line: <attribute key="boostpercentenergy" value="150" /> and its change nothing in player damage.

Reflect works good but boosts doesn't works.
I add to item attributes this line: <attribute key="boostpercentenergy" value="150" />
and its change nothing in player damage.

same problem here @nekiro

Boosts increase damage only on items, damage from spells not increase.

this was fixed with latest commit, test again

[tosty33]

Good to see that TFS is still being developed after all these years. I'm no longer active in the open tibia server community, but gonna assume that everything works fine as it got merged in the repository.

Bounty claim accepted, good work :)

[Zbizu]

conflict with mapeditor
https://github.com/otland/forgottenserver/blob/master/src/item.h#L110
https://github.com/Zbizu/rme/blob/master/source/iomap_otbm.h#L51

requesting moving them to 42 and 43 if possible (the longer we wait, the more people will end up having map/database conflicts)

[Sansero1]

thank you for your great work , i really appreciate it .
some of the attributes that wasn't working works fine at the moment like (boostpercentdamage,boostpercentphysical) but
im trying to add healing percentage to an item like
<attribute key="boostpercenthealing" value="75" />
but it doesn't work at all , so if you can look again at it that would be great.

[EPuncker]

thank you for your great work , i really appreciate it . some of the attributes that wasn't working works fine at the moment like (boostpercentdamage,boostpercentphysical) but im trying to add healing percentage to an item like <attribute key="boostpercenthealing" value="75" /> but it doesn't work at all , so if you can look again at it that would be great.

have you registered it at movements.xml?

[Sansero1]

thank you for your great work , i really appreciate it . some of the attributes that wasn't working works fine at the moment like (boostpercentdamage,boostpercentphysical) but im trying to add healing percentage to an item like <attribute key="boostpercenthealing" value="75" /> but it doesn't work at all , so if you can look again at it that would be great.

have you registered it at movements.xml?

yes i have , same as i did with boostpercentdamage and boostpercentphysical.

[Sansero1]

guys , you still working on this healing attribute ?
cause im waiting for this to be solved.

[nekiro]

guys , you still working on this healing attribute ? cause im waiting for this to be solved.

#4122
Here is the related issue, contribution is welcome.