new method itemType:getDecayTime()

[Zbizu]

fixed version of #1229 (added missing & symbol)
closes #1212

test results:

15:29 > print(ItemType("dead rat"):getDecayTime())	-> 300 /dead rat
15:29 > print(ItemType(2168):getDecayTime())		-> 1200 /life ring
15:29 > print(ItemType(2169):getDecayTime())		-> 600 /time ring
15:29 > print(ItemType(407):getDecayTime())		-> 0 /black tile floor
15:30 > print(ItemType(2640):getDecayTime())		-> 14400 /active soft boots
15:42 > print(ItemType.getDecayTime())			-> nil /empty value
15:42 > print(ItemType.getDecayTime({}))		-> nil /table as argument

didn't had a single crash

[nekiro]

this wont work for items that are not transformed on equip to anything else right?

[Zbizu]

good catch

16:08 > print(ItemType(2050):getDecayTime()) -> 0
16:08 > print(ItemType(2051):getDecayTime()) -> 600
16:09 > print(ItemType(2052):getDecayTime()) -> 0
16:09 > print(ItemType(2053):getDecayTime()) -> 300

what other flag could be used to return correct duration for just bought torch?

this is quite problematic because the transform happens in lua now and items.xml doesn't mention it anywhere

	<item id="2050" article="a" name="torch">
		<attribute key="slotType" value="ammo" />
		<attribute key="weight" value="500" />
		<attribute key="stopduration" value="1" />
	</item>
	<item id="2051" article="a" name="lit torch">
		<attribute key="slotType" value="ammo" />
		<attribute key="weight" value="500" />
		<attribute key="decayTo" value="2053" />
		<attribute key="duration" value="600" />
	</item>

edit: alright I think I found a solution, but it would be a weird override (not sure if suitable with tfs code style standards)

1. moving decayItems table from actions/scripts/other/decayTo.lua to libs
2. this

if not overrided then -- prevent loop disaster on reload
function ItemType:getDecayTime()
-- if original function gives 0 then search this global table and check the transformed item end
end
overrided = true
end

what do you think?

[Zbizu]

eventually we can do two different functions, like

• :getDecayTime() would work as current getDecayTime()
• :getBaseDecayTime() would be written in lua and check lua libs as well

otherwise it's probably not the greatest idea to hardcode a variable from some random lua file

[soul4soul]

@Zbizu I want to make you aware of https://github.com/gesior/forgottenserver/commit/395e6955a31fda12c1a48a37fbc017e2a373fc7b by @gesior. It adds support for decay by timestamp using a new ITEM_ATTRIBUTE_DECAY_TIMESTAMP attribute and 3 new lua methods. See #2641 for all the details.

item:getDurationLeft()
item:setDurationLeft(timeInMiliseconds)
item:stopDecay()

[Zbizu]

I was aware of his PR, but thought that it covers slightly different area than mine. I will watch his thread. Will reopen if his changes don't go through.