Say without echo in onHear event #3031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this modification you will be able to speak within the listening event without overflow problems when starting an infinite listening loop
robpot95
reviewed
May 8, 2020
|
To be honest I didn't want to add another parameter to creatureSay that is full of them already, but if it's necessary, then it would be nice to have it in creature:say(...) in lua as well. |
It is a hidden parameter, it is not handled from lua, the only thing that does this is detect if the |
DSpeichert
approved these changes
Feb 6, 2022
Znote
pushed a commit
to Znote/forgottenserver
that referenced
this pull request
Feb 23, 2022
With this modification you will be able to speak within the listening event without overflow problems when starting an infinite listening loop
DSpeichert
pushed a commit
that referenced
this pull request
May 9, 2022
With this modification you will be able to speak within the listening event without overflow problems when starting an infinite listening loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this modification you will be able to speak within the listening event without overflow problems when starting an infinite listening loop
This was mentioned in the following PR: #3001 and #3004
I decided to make my own version, it is quite simple and fix the problem perfectly, if this can be improved please tell me.