Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RevScriptSys Monster enhanced attack conditions #3499

Merged
merged 4 commits into from
Sep 26, 2021

Conversation

soul4soul
Copy link
Contributor

@soul4soul soul4soul commented Jul 10, 2021

Pull Request Prelude

Changes Proposed

Issues addressed:

  • Fix Revscriptsys Monster #3485
  • Refactor parsing revscriptsys monster attack and defense to use a common helper function
  • Allow conditions to be used with all predefine creature abilities. Conditions can be used with "melee", "combat", "speed", "condition", "outfit", "invisible", "*field", etc.. Conditions won't work with named spells such as "energy strike".

I verified conditions worked using these attack types.

monster.attacks = {
	{name = "melee", attack = 10, skill = 100, condition = { type = CONDITION_FIRE, minDamage = 50, maxDamage = 200, duration = 5000, interval = 1000}},
        {name = "condition", chance = 1000, range = 1, condition = { type = CONDITION_ENERGY, minDamage = 10, maxDamage = 20, duration = 5000, interval = 1000}},
        {name = "combat", type = COMBAT_LIFEDRAIN, chance = 100, interval = 2*1000, minDamage = 0, maxDamage = -10, target = true, range = 7, condition = { type = CONDITION_CURSED, minDamage = 10, maxDamage = 20, duration = 5000, interval = 1000}},
        {name = "speed", chance = 100, interval = 2000, speed = -500, target = true, range = 7, condition = { type = CONDITION_DROWN, minDamage = 20, maxDamage = 20, duration = 5000, interval = 1000}},
        {name = "firefield", chance = 100, interval = 2000, target = true, range = 7, condition = { type = CONDITION_FREEZING, minDamage = 20, maxDamage = 50, duration = 5000, interval = 1000}}
}

@EPuncker EPuncker requested a review from EvilHero90 July 10, 2021 23:47
EPuncker
EPuncker previously approved these changes Aug 28, 2021
@EPuncker EPuncker merged commit 1a5e3b1 into otland:master Sep 26, 2021
@soul4soul soul4soul deleted the rev_mon_combat_condition branch October 15, 2021 18:11
@ghost ghost mentioned this pull request Jan 21, 2022
3 tasks
@soul4soul soul4soul mentioned this pull request Feb 6, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revscriptsys Monster
3 participants