Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce broadcast range for container updates #3664

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

Erza
Copy link
Contributor

@Erza Erza commented Sep 17, 2021

Pull Request Prelude

Changes Proposed

Containers can never be opened if a player is more than 1 SQM away from it, hence we are doing unnecessary work here by sending updates to clients that are too far away from the container

Issues addressed:

@DSpeichert DSpeichert merged commit d156f95 into otland:master Sep 17, 2021
@nekiro
Copy link
Member

nekiro commented Sep 18, 2021

why are we looping twice though in these methods? Instead of once and execute both methods (sendUpdate, onUpdate)

@Erza
Copy link
Contributor Author

Erza commented Sep 18, 2021

why are we looping twice though in these methods? Instead of once and execute both methods (sendUpdate, onUpdate)

I don't know either, but it is like that all over the codebase. Once I read a comment somewhere on this repo about there being a possible race condition if it's not done this way? Might be wrong tho

@Erza Erza deleted the container-range branch September 18, 2021 21:28
@Znote Znote mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants